Disable 'Save as draft' when 'Moving backwards' is disabled #5647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
reviewed
Jun 28, 2023
| import org.odk.collect.android.support.rules.TestRuleChain | ||
|
|
||
| @RunWith(AndroidJUnit4::class) | ||
| class MovingBackwardsTest { |
There was a problem hiding this comment.
What's the thinking around adding this instead of adding tests to FormEntryAccessPreferencesFragmentTest?
There was a problem hiding this comment.
We can't test disabling moving backwards in isolation (using fragment-scenario like in FormEntryAccessPreferencesFragmentTest) because that fragment displays MovingBackwardsDialog which calls a listener from ProjectPreferencesActivity and then it calls a method from FormEntryAccessPreferencesFragment, so there is that activity involved.
seadowg
requested changes
Jul 4, 2023
...ect_app/src/androidTest/java/org/odk/collect/android/feature/settings/MovingBackwardsTest.kt
Outdated
Show resolved
Hide resolved
seadowg
approved these changes
Jul 5, 2023
|
Tested with Success! Verified on device with Android 13 Verified cases:
|
|
Tested with Success! Verified on device with Android 10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5148
What has been done to verify that this works as intended?
I've tested the fix manually and added automated tests.
Why is this the best possible solution? Were any other approaches considered?
There is not much to discuss here. I've handled that new setting in the same way like other settings related to moving backwards/editing forms.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Please test the case described in the issue and generally that the settings that should be disabled when moving backwards is disabled are handled properly.
It's also important to make sure that settings are migrated properly. For example, if moving backwards was disabled in the previous version after upgrading
Save as draftshould be disabled, andFinalizeshould be enabled (in Settings -> Access control -> Form Entry Settings).Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.