Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the end screen warning text based on the available actions #5591

Merged
merged 3 commits into from
May 25, 2023

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented May 17, 2023

Closes #5584

What has been done to verify that this works as intended?

I've tested the fix manually and added automated tests.

Why is this the best possible solution? Were any other approaches considered?

This is what we discussed in the issue.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Please just verify the warning is displayed according to the available actions as described in the issue.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review May 17, 2023 14:40
@grzesiek2010 grzesiek2010 requested a review from seadowg May 17, 2023 14:40
@seadowg
Copy link
Member

seadowg commented May 22, 2023

@getodk/testers the different messages are all described here in the issue.

@dbemke
Copy link

dbemke commented May 22, 2023

The end page of a form is not shown correctly when Save as draft / Finalize is disabled and in auto-send settings there is wifi/wifi or cellular.
endpage

Steps to reproduce:

  1. Go to Settings → Access control → Form Entry Settings
  2. Disable Save as draft or Finalize.
  3. Go to Settings →Form management → Auto send
  4. Choose wifi only/ wifi or cellular
  5. Open a form and go to the end page.

When Auto send is set to off or cellular only the issue doesn’t occur. The issue doesn’t occur on the master version.

@grzesiek2010
Copy link
Member Author

@dbemke The problem should be fixed.

@grzesiek2010 grzesiek2010 changed the title Update the end screen warning text based on the available actions #5584 Update the end screen warning text based on the available actions May 23, 2023
@srujner
Copy link

srujner commented May 25, 2023

@dbemke already checked all items from the verified cases yesterday

Tested with Success!

Verified on device with Android: 10, 13

Verified cases:

  • Acceptance Criteria from Update the end screen warning text based on the available actions #5584 has been met;
  • auto send: off, wifi only, cellular, wifi or cellular
  • with/without SIM card
  • wifi on/off
  • switching between projects with different settings in auto send
  • changing auto send settings in duplicate project
  • auto sending submissions
  • sending submissions manually
  • finilizing an edited form
  • form with auto send set to true/false and auto delete set to true/false

@grzesiek2010 grzesiek2010 merged commit 6e5cdae into getodk:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the end screen warning text based on the available actions
4 participants