-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form error improvements #5560
Form error improvements #5560
Conversation
21fd905
to
12adf6e
Compare
Following the steps in #5507 allows to save a draft or send the form. |
To me it seems right. It works in the same way like before right so reopening such a form is not possible? If so it's fine. I didn't change that behavior. What I've fixed regarding that issue is recreating that error dialog what I've described in #5507 (comment)
|
Tested with Success! Verified on device with Android 12 and 13 Verified cases:
|
Closes #5507
Closes #5361
What has been done to verify that this works as intended?
I've tested the changes manually and added automated tests.
Why is this the best possible solution? Were any other approaches considered?
As discussed in the issue we have two types of errors (non-fatal and fatal). If a form contains a non-fatal error there is no need to remember it and restore it when the activity is recreated. If it's a fatal error of course the form view should be closed immediately after clicking the OK button.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Please test both types of form design errors. I don't see anything that should be reviewed more carefully.
Do we need any specific form for testing your changes? If so, please attach one.
The forms that are attached to the issues represent non-fatal errors. If you have a form with a fatal error that closes the form view immediately after clicking the OK button then please use it if not you can use the one we have in this test https://github.com/getodk/collect/pull/5560/files#diff-ecc5077e0136dfcd8dedd8caa30a17ecf92399b13200c97e9661a44a7fcd0bd4R24
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.