Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved logging SQLiteBlobTooBigException #5541

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Apr 5, 2023

What has been done to verify that this works as intended?

I've reviewed implemented changes.

Why is this the best possible solution? Were any other approaches considered?

In #5529 we added logging SQLiteBlobTooBigException with cursor size. We have some new reports (see https://console.firebase.google.com/u/0/project/api-project-322300403941/crashlytics/app/android:org.odk.collect.android/issues/1d44e46d70a9c63deff958a80ea8ef4d?time=last-seven-days&versions=v2023.1.2%20(4616);v2023.1.1%20(4615)&types=crash&sessionEventKey=642C2E56030400014FA76152CCDD6761_1796641706817802731) and in all cases, the size is 2MB so it should be more than enough for us.

I have one more idea to check before I will assume it's magic and it's not possible to fix it... I think that maybe the cursor size is very small initially and when the exception happens it is increased and everything works fine. Actually, that would explain why it only happens once (the number of users and events is the same).
To verify my theory I improved logging the exception and now I read the cursor size before the exception takes place.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It doesn't require testing.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 requested a review from seadowg April 5, 2023 22:49
@seadowg seadowg added this to the v2023.1.x milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

2 participants