Improved logging SQLiteBlobTooBigException #5541
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done to verify that this works as intended?
I've reviewed implemented changes.
Why is this the best possible solution? Were any other approaches considered?
In #5529 we added logging
SQLiteBlobTooBigException
with cursor size. We have some new reports (see https://console.firebase.google.com/u/0/project/api-project-322300403941/crashlytics/app/android:org.odk.collect.android/issues/1d44e46d70a9c63deff958a80ea8ef4d?time=last-seven-days&versions=v2023.1.2%20(4616);v2023.1.1%20(4615)&types=crash&sessionEventKey=642C2E56030400014FA76152CCDD6761_1796641706817802731) and in all cases, the size is 2MB so it should be more than enough for us.I have one more idea to check before I will assume it's magic and it's not possible to fix it... I think that maybe the cursor size is very small initially and when the exception happens it is increased and everything works fine. Actually, that would explain why it only happens once (the number of users and events is the same).
To verify my theory I improved logging the exception and now I read the cursor size before the exception takes place.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It doesn't require testing.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.