Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shapes more transparent #5509

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Make shapes more transparent #5509

merged 1 commit into from
Mar 22, 2023

Conversation

lognaturel
Copy link
Member

@lognaturel lognaturel commented Mar 22, 2023

Minor follow-on to #5478. @grzesiek2010 had said "the red color used for filling the area of polygons could be brighter/more transparent."

I tried various values and landed on 25% transparency. I think the contrast between the border and the contents is helpful and the lightness makes it easier to actually look at the shape without being overwhelmed.

Before:

After:
lighter

What has been done to verify that this works as intended?

Tried it with OSM.

Why is this the best possible solution? Were any other approaches considered?

I briefly explored more orange or lighter shades. The transparency change is what had a big impact. I have a slight preference for a more orange red side-by-side (like ff3300) but I don’t think it really matters.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

we haven’t released any of this and it’s just an alpha change.

Do we need any specific form for testing your changes? If so, please attach one.

See original PR.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg removed the request for review from grzesiek2010 March 22, 2023 08:24
@seadowg seadowg merged commit 605a6b9 into getodk:master Mar 22, 2023
@lognaturel lognaturel deleted the shape-alpha branch March 22, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants