-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworked the way we display images in ImageWidgets #5433
Conversation
@grzesiek2010 this needs conflicts resolved. |
…displayed if there is no answer
…swer can not be loaded
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a bonus it makes the show/hide flow for error text clearer. Tests look complete to me.
The "Markup image" button is enabled after adding an invalid image and there is a crash when a user taps the markup button. (Android 10,13)
|
This is something we also should fix but it throws a different stacktrace so it's not the main issue I wanted to address. Please file a separate issue and we can add it to v2023.2. |
Tested with Success! Verified on device with Android: 5.1, 12 and 13 Verified Cases:
|
Tested with Success! Verified on device with Android: 8.1, 10, 11 |
Closes #5430
What has been done to verify that this works as intended?
I've checked the fix manually and added some automated tests.
Why is this the best possible solution? Were any other approaches considered?
It seems to be a bug in Glide bumptech/glide#4035. I've improved the was we display/hide images so that the bug doesn't affect our app. I didn't think of any other solution.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This may affect any image widget Image/Draw/Annotate/Signature so please test all of them.
Do we need any specific form for testing your changes? If so, please attach one.
The
AllWidgets
form.Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.