Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spaces between commas in CSVs #3111

Merged
merged 1 commit into from
May 29, 2019

Conversation

lognaturel
Copy link
Member

@lognaturel lognaturel commented May 29, 2019

Closes #3110

What has been done to verify that this works as intended?

Visual inspection and updating tests.

Why is this the best possible solution? Were any other approaches considered?

Trivial change with no alternatives.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

There's a potential risk of breaking downstream integrations that didn't strip whitespace. Strictly speaking, the column headers have been node, start, etc with a prepended space. I think it's best to make this correction as soon as possible.

Do we need any specific form for testing your changes? If so, please attach one.

Any form with audit logging such as trackingChangesTestForm.xml.txt

Does this change require updates to documentation? If so, please file an issue here and include the link below.

getodk/xforms-spec#234

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 merged commit ad88868 into getodk:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit CSV header row should not include spaces between column names
2 participants