Improved testing form errors

getodk · Aug 21, 2024 · efe2c60 · efe2c60
1 parent 405ccf2
commit efe2c60
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 131 deletions.
diff --git a/...ect_app/src/androidTest/java/org/odk/collect/android/feature/formentry/InvalidFormTest.kt b/...ect_app/src/androidTest/java/org/odk/collect/android/feature/formentry/InvalidFormTest.kt
@@ -28,34 +28,21 @@ class InvalidFormTest {
     }
 
     @Test
-    fun app_ShouldNotCrash_whenFillingFormsWithErrors() {
-        rule.startAtMainMenu()
-            .copyForm("g6Error.xml")
-            .startBlankFormWithError("g6Error")
-            .clickOK(FormEntryPage("g6Error"))
-            .swipeToEndScreen()
-            .clickFinalize()
-            .checkIsSnackbarWithMessageDisplayed(R.string.form_saved)
-
-        MainMenuPage()
-            .copyForm("g6Error2.xml")
-            .startBlankForm("g6Error2")
-            .swipeToNextQuestionWithError()
-            .clickOK(FormEntryPage("g6Error2"))
-            .swipeToEndScreen()
-            .clickFinalize()
-            .checkIsSnackbarWithMessageDisplayed(R.string.form_saved)
-
+    fun app_ShouldNotCrash_whenFillingFormsWithEmptyGroupFieldList() {
         MainMenuPage()
             .copyForm("emptyGroupFieldList.xml")
             .clickFillBlankForm()
             .clickOnEmptyForm("emptyGroupFieldList")
             .clickFinalize()
             .checkIsSnackbarWithMessageDisplayed(R.string.form_saved)
+    }
 
-        MainMenuPage()
-            .copyForm("emptyGroupFieldList2.xml")
-            .startBlankForm("emptyGroupFieldList2")
+    @Test
+    fun app_ShouldNotCrash_whenFillingFormsWithRepeatInFieldList() {
+        rule.startAtMainMenu()
+            .copyForm("repeat_in_field_list.xml")
+            .startBlankFormWithError("repeat_in_field_list")
+            .clickOK(FormEntryPage("repeat_in_field_list"))
             .swipeToEndScreen()
             .clickFinalize()
             .checkIsSnackbarWithMessageDisplayed(R.string.form_saved)

diff --git a/test-forms/src/main/resources/forms/emptyGroupFieldList2.xml b/test-forms/src/main/resources/forms/emptyGroupFieldList2.xml
diff --git a/test-forms/src/main/resources/forms/g6Error2.xml b/test-forms/src/main/resources/forms/g6Error2.xml
diff --git a/...orms/src/main/resources/forms/g6Error.xml → .../resources/forms/repeat_in_field_list.xml b/...orms/src/main/resources/forms/g6Error.xml → .../resources/forms/repeat_in_field_list.xml
@@ -1,9 +1,9 @@
 <h:html xmlns="http://www.w3.org/2002/xforms" xmlns:h="http://www.w3.org/1999/xhtml" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:jr="http://openrosa.org/javarosa">
   <h:head>
-    <h:title>g6Error</h:title>
+    <h:title>repeat_in_field_list</h:title>
     <model>
       <instance>
-        <data id="build_g6Error_1517568408">
+        <data id="repeat_in_field_list">
           <meta>
             <instanceID/>
           </meta>