Exit early if function have already bee found

getodk · Dec 4, 2023 · b4f2941 · b4f2941
1 parent 101f858
commit b4f2941
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/.../src/main/java/org/odk/collect/android/dynamicpreload/DynamicPreloadXFormParserFactory.kt b/.../src/main/java/org/odk/collect/android/dynamicpreload/DynamicPreloadXFormParserFactory.kt
@@ -30,12 +30,20 @@ class DynamicPreloadParseProcessor :
     private var containsSearch = false
 
     override fun processXPath(xPathExpression: XPathExpression) {
+        if (containsPullData) {
+            return // No need to search if we already found pulldata
+        }
+
         if (xPathExpression.containsFunc("pulldata")) {
             containsPullData = true
         }
     }
 
     override fun processQuestion(question: QuestionDef) {
+        if (containsSearch) {
+            return // No need to search if we already found search
+        }
+
         if (ExternalDataUtil.getSearchXPathExpression(question.appearanceAttr) != null) {
             containsSearch = true
         }