Skip to content

Commit

Permalink
lint: switch to using eslint directly (#827)
Browse files Browse the repository at this point in the history
* this allows the use of the --cache flag for faster repeated linting (not
  supported in `vue-cli-service lint`)
  see: https://cli.vuejs.org/core-plugins/eslint.html#injected-commands
* `vue-cli-service` is deprecated, and using `eslint` directly is recommended
  for vue 3
  see: https://cli.vuejs.org/core-plugins/eslint.html
  see: https://vuejs.org/guide/scaling-up/tooling.html#linting

---------

Co-authored-by: alxndrsn <alxndrsn>
Co-authored-by: Matthew White <[email protected]>
  • Loading branch information
alxndrsn and matthew-white authored May 9, 2024
1 parent a54cf7b commit 18159e7
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 193 deletions.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,5 @@ npm-debug.log*

/.nginx/*
!/.nginx/.gitkeep

/.eslintcache
190 changes: 2 additions & 188 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
"dev": "nf start",
"dev:oidc": "VUE_APP_OIDC_ENABLED=true npm run dev",
"build": "vue-cli-service build",
"lint": "vue-cli-service lint --no-fix --max-warnings 0 src/ bin/ test/ *.js",
"lint:fix": "vue-cli-service lint --fix --max-warnings 0 src/ bin/ test/ *.js",
"lint": "eslint --max-warnings 0 --cache --ext .js,.vue src/ bin/ test/ *.js",
"lint:fix": "eslint --max-warnings 0 --fix --cache --ext .js,.vue src/ bin/ test/ *.js",
"test": "./test/run.sh"
},
"volta": {
Expand Down Expand Up @@ -38,7 +38,6 @@
},
"devDependencies": {
"@intlify/vue-i18n-loader": "~4",
"@vue/cli-plugin-eslint": "^5.0.8",
"@vue/cli-service": "^5.0.8",
"@vue/compiler-sfc": "~3",
"@vue/eslint-config-airbnb": "^7.0.0",
Expand All @@ -62,7 +61,8 @@
"should": "~13.2",
"sinon": "~9",
"util": "^0.12.5",
"vue-cli-plugin-i18n": "~2"
"vue-cli-plugin-i18n": "~2",
"yorkie": "^2.0.0"
},
"engines": {
"node": "20",
Expand Down
1 change: 0 additions & 1 deletion vue.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ module.exports = {
css: { url: false }
}
},
lintOnSave: false,
pluginOptions: {
i18n: {
locale: 'en',
Expand Down

0 comments on commit 18159e7

Please sign in to comment.