Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match file extension to type #1247

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Match file extension to type #1247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/api.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3670,7 +3670,7 @@ paths:
items:
$ref: '#/components/schemas/FormAttachment'
example:
- name: myfile.mp3
- name: myfile.png
type: image
exists: true
blobExists: true
Expand Down Expand Up @@ -4198,7 +4198,7 @@ paths:
items:
$ref: '#/components/schemas/FormAttachment'
example:
- name: myfile.mp3
- name: myfile.png
type: image
exists: true
blobExists: true
Expand Down Expand Up @@ -4899,7 +4899,7 @@ paths:
items:
$ref: '#/components/schemas/FormAttachment'
example:
- name: myfile.mp3
- name: myfile.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these 3 changes make sense 👍

type: image
exists: true
blobExists: true
Expand Down Expand Up @@ -12264,7 +12264,7 @@ components:
properties:
name:
type: string
example: myfile.mp3
example: myfile.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was wrong with this file being a PNG?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either way would be fine, but I think the consistency doesn't hurt.

description: The name of the file as specified in the XForm.
type:
$ref: '#/components/schemas/FormAttachmentType'
Expand Down Expand Up @@ -12659,7 +12659,7 @@ components:
properties:
name:
type: string
example: myfile.mp3
example: myfile.png
description: The name of the file as specified in the Submission XML.
exists:
type: boolean
Expand Down