Use custom namespace for asio to prevent UE collision #418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #404 by renaming the
asio
namespace toasio_sockio
as well as any global functions in the asio library.This PR is dependent on these PRs:
This currently PR does not update the submodules as it didn't make sense to make a PR that referenced downstream repos temporarily until the dependent PRs are merged into the upstream repos. I can update this PR to have the updated submodules once those other PRs are merged, but you can also merge beforehand and update the submodules yourself if you'd prefer.
If you want to test these changes, the easiest way is to test the forked
redwood
branch from https://github.com/redwoodmmo/SocketIOClient-Unreal/ which resembles the final merged state (other than a change to the plugin's engine version)