Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lex Support #8533

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Lex Support #8533

wants to merge 3 commits into from

Conversation

jamarcelin
Copy link
Contributor

No description provided.

@jamarcelin
Copy link
Contributor Author

@bblommers Hello! I just started on this Lex Module and I am getting this error in base_backend.py when I run the test test_create_bot (It's not supposed to pass). I am getting this error:

E ModuleNotFoundError: No module named 'moto.lexv2urls'

Any idea why its looking for a lexv2urls?

@bblommers
Copy link
Collaborator

Hi @jamarcelin! That was essentially a bug in our core logic. In order to find find the urls.py-file for any given service, we take the name of the models-file (moto.service.models), replaced models with urls, and assumed that the result (moto.service.urls) was always correct.
That obviously doesn't work when the service name contains the word models, as it then tries to find moto.lexv2urls.urls, which doesn't exist. I've pushed a fix to the logic itself, so we can keep using the same service name.

(I've just realized that I haven't tested whether this breaks any other services... I expect it to be OK, but I'll keep an eye out. Please tag me again if you see anything else breaking because of this change. 🙂 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants