Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ElastiCache] Add support for AuthenticationMode for create_user #8494

Merged
merged 5 commits into from
Jan 19, 2025

Conversation

jflim
Copy link
Contributor

@jflim jflim commented Jan 15, 2025

Fixes #8473

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.63%. Comparing base (4c1321a) to head (b0cffab).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
moto/elasticache/responses.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8494      +/-   ##
==========================================
- Coverage   92.63%   92.63%   -0.01%     
==========================================
  Files        1224     1224              
  Lines      105925   105960      +35     
==========================================
+ Hits        98123    98153      +30     
- Misses       7802     7807       +5     
Flag Coverage Δ
servertests 27.75% <36.58%> (+<0.01%) ⬆️
unittests 92.60% <97.56%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bpandola bpandola self-assigned this Jan 19, 2025
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you @jflim!

@bblommers bblommers added this to the 5.0.27 milestone Jan 19, 2025
@bblommers bblommers merged commit a3472d3 into getmoto:master Jan 19, 2025
53 checks passed
@bpandola bpandola removed their assignment Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elasticache: Add initial support for IAM authentication for ElastiCache Redis users
3 participants