Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StepFunctions: Various upgrades #8396

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

bblommers
Copy link
Collaborator

@bblommers bblommers commented Dec 14, 2024

All the Stepfunctions improvements included in LocalStack since #7938

Included is a script to simplify this partially for next time.
Manual steps (to be automated):

  • Remove LS-specific service integration
  • Remove jsonata, as it relies on an external Java package
  • Remove Python 3.9/3.10 typing (dict vs Dict, list vs List, etc)

Fixes #7826

A ton of changes, but that's mostly because it's been a while since the last update. Now that we have a script it should be faster though.

@bblommers bblommers added this to the 5.0.23 milestone Dec 14, 2024
@bblommers bblommers force-pushed the stepfunctions-improvements-2 branch 4 times, most recently from 6a52cb1 to ba6858d Compare December 14, 2024 22:23
@bblommers bblommers marked this pull request as draft December 15, 2024 11:04
@bblommers bblommers force-pushed the stepfunctions-improvements-2 branch from ba6858d to bf58f41 Compare December 15, 2024 11:07
@bblommers bblommers removed this from the 5.0.23 milestone Dec 15, 2024
@bblommers bblommers force-pushed the stepfunctions-improvements-2 branch 3 times, most recently from ded60d1 to aa2ac9f Compare December 17, 2024 20:50
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 55.88990% with 1891 lines in your changes missing coverage. Please review.

Project coverage is 92.62%. Comparing base (5ab97e5) to head (459b394).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...oto/stepfunctions/parser/asl/parse/preprocessor.py 42.27% 284 Missing ⚠️
...ctions/parser/asl/parse/test_state/preprocessor.py 0.00% 84 Missing ⚠️
...oto/stepfunctions/parser/asl/eval/event/logging.py 35.65% 83 Missing ⚠️
...nent/state/exec/state_task/state_task_activitiy.py 22.89% 64 Missing ⚠️
.../iteration/iterator/distributed_iterator_worker.py 24.28% 53 Missing ⚠️
...exec/state_task/service/state_task_service_glue.py 41.97% 47 Missing ⚠️
...xec/state_task/service/state_task_service_batch.py 38.66% 46 Missing ⚠️
...ic_analyser/variable_references_static_analyser.py 40.62% 38 Missing ⚠️
...component/test_state/program/test_state_program.py 0.00% 36 Missing ⚠️
...l/static_analyser/usage_metrics_static_analyser.py 0.00% 35 Missing ⚠️
... and 109 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8396      +/-   ##
==========================================
- Coverage   94.60%   92.62%   -1.99%     
==========================================
  Files        1168     1225      +57     
  Lines      101707   105594    +3887     
==========================================
+ Hits        96220    97804    +1584     
- Misses       5487     7790    +2303     
Flag Coverage Δ
servertests 27.75% <0.04%> (-1.07%) ⬇️
unittests 92.59% <55.88%> (-1.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers force-pushed the stepfunctions-improvements-2 branch from aa2ac9f to 459b394 Compare December 26, 2024 19:39
@bblommers bblommers added this to the 5.0.25 milestone Dec 26, 2024
@bblommers bblommers marked this pull request as ready for review December 26, 2024 20:30
@bblommers bblommers merged commit b307122 into getmoto:master Dec 26, 2024
50 of 53 checks passed
@bblommers bblommers deleted the stepfunctions-improvements-2 branch December 26, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Step function creation errors when using specific IAM roles within steps
1 participant