EC2: Add default DHCP options set for VPCs #6901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6901 +/- ##
==========================================
- Coverage 95.82% 95.82% -0.01%
==========================================
Files 826 826
Lines 80961 80976 +15
==========================================
+ Hits 77579 77593 +14
- Misses 3382 3383 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bblommers
approved these changes
Oct 11, 2023
|
This is now part of moto >= 4.2.6.dev29 |
toshyak
pushed a commit
to toshyak/moto
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS provides the
AssociateDhcpOptionsoperation to associate a DHCP Options Set with a VPC.There is no
DisassociateDhcpOptionsoperation to remove a DHCP Options Set from a VPC. Instead,DhcpOptionsIdmust be set todefaultwhen callingAssociateDhcpOptionsto achieve this.This PR implements this capability.
See: https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_AssociateDhcpOptions.html#API_AssociateDhcpOptions_RequestParameters
Closes: localstack/localstack#9222