-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch: arraySize and child jobs #6541
Conversation
Technically it does satisfy requirements from #6512 but doing it on the response, rather than in the model, feels doesn't feel quite right. I originally tried with a |
@rafcio19 If I understand the docs correctly, we should actually execute the same job As a potential solution: Note that I haven't looked at the implementation in a while, so I don't know how feasible it is. But that's probably the most similar to how AWS behaves. |
BTW, I would be happy to have a go at the implementation, I just don't know when/if I have time in the coming days. |
Thanks for the tips, leave it with me for another while. |
…und with response object
4951163
to
18ad5f3
Compare
Hey @rafcio19 @bblommers |
Hey chaps, I haven't had much time to devote to moto since the summer. If someone else wants to have a go then please do; or you could 🤞 and give me a few weeks. |
Hey @rafcio19, I just had a crack at it. Instead of an Based on my testing, this is all in-line with how AWS behaves |
Go nuts @bblommers, I've had it long enough. Will try to pick up more moto issues in the near future |
a00f396
to
301d385
Compare
Codecov Report
@@ Coverage Diff @@
## master #6541 +/- ##
========================================
Coverage 95.81% 95.82%
========================================
Files 821 826 +5
Lines 80624 81042 +418
========================================
+ Hits 77249 77655 +406
- Misses 3375 3387 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is now part of moto >= 4.2.6.dev30 |
Closes #6512