Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Dependency Injection, remove framework #251

Merged
merged 21 commits into from
Oct 18, 2023
Merged

Simplify Dependency Injection, remove framework #251

merged 21 commits into from
Oct 18, 2023

Conversation

kienstra
Copy link
Member

@kienstra kienstra commented Oct 16, 2023 •
edited
Loading

Changes

  • Remove inversify, the dependency injection framework
  • Replace it with a composition root
  • Now, you can see where all of the instances come from:

local-ci/src/CompositionRoot.ts

Lines 204 to 213 in 076378c

const registrarFactory = new RegistrarFactory(
new Complain(editorGateway),
configFile,
createConfigFile,
debugRepo,
new EnterLicense(licenseInput),
enterToken,
exitAllJobs,
exitJob,
new FirstActivation(editorGateway, reporterGateway, email),

kienstra added 21 commits October 15, 2023 15:48
@kienstra
Refactor to simple constructor injection
8d171df
@kienstra
Get new instances from the container in every test
0307486
@kienstra
Fix order in AppRoot.ts
dff8c20
@kienstra
Move main app root and test root away from each other
a9ac948
@kienstra
Get the volume from the container
3c8e69d
@kienstra
Merge branch 'develop' into update/simpler-di
6753529
@kienstra
Remove reflect-metadata
696ef50
@kienstra
Make one of the full tests pass
5ce46c3
@kienstra
Fix alphabetization
49bf870
@kienstra
Will revert: remove test for fixture
b32a6f5
@kienstra
Remove unused imports
22358f5
@kienstra
Revert "Remove unused imports"
40f1645 
This reverts commit 22358f5.
@kienstra
Revert "Will revert: remove test for fixture"
9450a45 
This reverts commit b32a6f5.
@kienstra
Remove reflect-metadata from types
a7f09e6
@kienstra
Make unit tests pass again
7aac91b
@kienstra
Rename localCi to app
076378c
@kienstra
Simplify test for AllConfigFiles
d7ec2c7
@kienstra
Alphabetize the imports
094fb3e
@kienstra
Remove beforeEach, get the instances in each test
7148b51
@kienstra
Remove needless JSDoc comments
b8f10d5
@kienstra
Change the order of the imports
545ed11
@kienstra kienstra merged commit 0b38efb into develop Oct 18, 2023
@kienstra kienstra deleted the update/simpler-di branch October 18, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kienstra