fix(eslint-plugin-nestjs-tools): improve ambiguous condition

getlarge · Sep 19, 2024 · 6821758 · 6821758
1 parent 74f04bf
commit 6821758
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/packages/eslint-plugin/src/lib/return-class-instance.ts b/packages/eslint-plugin/src/lib/return-class-instance.ts
@@ -189,12 +189,16 @@ export const rule = ESLintUtils.RuleCreator(() => __filename)({
           if (extractedTypes.every(isValidReturnType)) {
             return;
           }
-          const returnStatements = node.value?.body?.body?.filter((node) => node.type === 'ReturnStatement') ?? [];
-          const methodReturnsClassInstance = returnStatements.every((returnStatement) =>
-            returnStatement.argument
-              ? doesReturnClassInstance(returnStatement.argument, typeName, extractedTypes)
-              : false,
-          );
+
+          const returnStatements = node.value?.body?.body?.filter((node) => node.type === 'ReturnStatement');
+          const methodReturnsClassInstance = returnStatements
+            ? returnStatements.every((returnStatement) =>
+                returnStatement.argument
+                  ? doesReturnClassInstance(returnStatement.argument, typeName, extractedTypes)
+                  : false,
+              )
+            : false;
+
           if (!methodReturnsClassInstance) {
             context.report({
               node,