Added consumer-tests #184
Open
Added consumer-tests #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding this so GitHub links this back to the issue: Closes https://github.com/getlantern/engineering/issues/300 |
|
@AGMETEOR would you have time to look at this PR if we resolve the merge conflicts? |
|
@hwh33 yes, I can take a look. Please add me as a reviewer when conflicts solved. |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FSMStateX anonymous functions have been pulled out into constructor functions so each state could be tested separately without relying on the previous FSMStates. I also added some empty test functions for paths that FSMStates are expected to fail, to be filled in later (commented out so they don't run).