Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: unify coupons experience #1985

Merged
merged 4 commits into from
Jan 10, 2025
Merged

misc: unify coupons experience #1985

merged 4 commits into from
Jan 10, 2025

Conversation

ansmonjol
Copy link
Collaborator

Context

We figured out we had discrepancy in the coupon actions over the app.

  1. You were able to terminate a coupon anytime from the details, but not from the coupon list (conditionally)
  2. You were not able to terminate a coupon from the details page

Description

This PR fixes those and also

  • displays the coupon status in the details page. After adding the terminate action it was blurry about the coupon status there.
  • make sure active queries (coupon details, delete or terminate coupon) are not fired again after a coupon is deleted. That used to trigger an error modal in the app before redirection to coupon list
  • display the correct wording in the delete coupon modal depending if the coupon have been applied to a customer or not

Fixes ISSUE-620

@ansmonjol ansmonjol enabled auto-merge (rebase) January 10, 2025 09:53
@ansmonjol ansmonjol merged commit e7e99a0 into main Jan 10, 2025
12 checks passed
@ansmonjol ansmonjol deleted the better-coupons-experience branch January 10, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants