-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Credit note export & filtering #1930
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenlago99
changed the title
Draft: (feat) Credit note export
(feat) Credit note export & filtering
Dec 23, 2024
stephenlago99
force-pushed
the
feat-credit-note-export
branch
from
December 23, 2024 12:05
aae914a
to
db29d05
Compare
stephenlago99
requested review from
ansmonjol
and removed request for
ansmonjol
December 23, 2024 12:06
ansmonjol
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Dive-in is available at:
[FE] [Dive-in] Credit note export
.This pull request handles filtering and exporting for credit notes.
Description
Exporting
To make it easier for future us to create export dialogs for different entities, the
ExportInvoiceDialog
was made general and transformed intoExportDialog
. This will enable us to quickly re-use it for future entities. Because of the current structure of the InvoicesPage, which embeds both Invoices and Credit notes, it might look weird that we have it defined 2 times, but in the future, when the credit notes tab will be extracted, this won't be the case.Filtering
To aid the inclusion of the existing Filters in the credit note page, some changes have been made to the bits and pieces that handled filters:
Future possible improvements:
InvoicesPage
componentFixes LAGO-624
Fixes LAGO-625