Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate json editor component #1924

Merged
merged 3 commits into from
Dec 19, 2024
Merged

refactor: migrate json editor component #1924

merged 3 commits into from
Dec 19, 2024

Conversation

keellyp
Copy link
Collaborator

@keellyp keellyp commented Dec 16, 2024

Context

Related to Tailwind Migration

Description

  • Extract custom react-ace style into a specific file
  • Remove usage of <Fade> from MUI in favour of Tailwind
  • Remove usage of styled-component

Fixes LAGO-431

@keellyp keellyp self-assigned this Dec 16, 2024
@keellyp keellyp force-pushed the lago-431-json-editor branch from ebaa598 to d1329cf Compare December 16, 2024 15:36
Copy link
Collaborator

@stephenlago99 stephenlago99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@keellyp keellyp merged commit f035151 into main Dec 19, 2024
8 checks passed
@keellyp keellyp deleted the lago-431-json-editor branch December 19, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants