Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As part of our ongoing journey to migrate from styled components to tailwind, the Table component also needed refactoring.
Description
Few points to note about this migration:
className
for "default" and toggled stylesstyles
for "dynamic" styles mapped on variablessx
for "complex" selector (specific classes, pseudo elements, ...)lago-*
are not in variables. Even tho they are used multiple times, I had to prevent using variables because we cannot use dynamic classe names insx
selector. Those are not interpreted during run time but build and "transformed" as static css on the flight. Even with unchanged const it don't work.setResponsiveProperty
and added a test for it. Also even tho this util is only used in Table today I preferred to keep it in it's separated file. It now return an object and not a component css object anymore.captionHl
defined in a style ofTableInnerCell
. I choose not to turn that into a TW className that could help, but rather keep it like this and maybe migrate later if sure reproduce too often.There should be no change in UI and UX
Fixes LAGO-422