misc: change Netsuite item mapping UX #1850
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
You can map a Lago item (collection or unique item) to an item in Netsuite.
The Process was the following
Main problem, the max amount of item you can fetch on Netsuite is 1000 and there is no pagination. It's a hard limit.
Description
This PR changes the way we enter mapping informations.
Now, you have to fill in manually the informations we were pre-fetching and selecting when picking an item in the Netsuite item list.
We pass from 1 combobox to 3 fields.
Note it was already the case if the item was a tax type.
It almost make this component simpler.
Fixes LAGO-504