Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: change Netsuite item mapping UX #1850

Merged
merged 2 commits into from
Nov 6, 2024
Merged

misc: change Netsuite item mapping UX #1850

merged 2 commits into from
Nov 6, 2024

Conversation

ansmonjol
Copy link
Collaborator

Context

You can map a Lago item (collection or unique item) to an item in Netsuite.

The Process was the following

  • open mapping modal on a Lago item
  • Under the hood we fetch Netsuite items
  • select a Netsuite mapping item
  • save the mapping to attach the two items together (saved in Lago DB)

Main problem, the max amount of item you can fetch on Netsuite is 1000 and there is no pagination. It's a hard limit.

Description

This PR changes the way we enter mapping informations.
Now, you have to fill in manually the informations we were pre-fetching and selecting when picking an item in the Netsuite item list.

We pass from 1 combobox to 3 fields.

Note it was already the case if the item was a tax type.
It almost make this component simpler.

Fixes LAGO-504

@ansmonjol ansmonjol self-assigned this Nov 5, 2024
@ansmonjol ansmonjol force-pushed the netsuite-mapping branch 2 times, most recently from 8fc9b1c to c1b2c19 Compare November 6, 2024 09:17
@ansmonjol ansmonjol enabled auto-merge (rebase) November 6, 2024 09:38
@ansmonjol ansmonjol merged commit 54af0cc into main Nov 6, 2024
6 checks passed
@ansmonjol ansmonjol deleted the netsuite-mapping branch November 6, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants