Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate eslint to v9 #1846

Merged
merged 14 commits into from
Nov 13, 2024
Merged

chore: migrate eslint to v9 #1846

merged 14 commits into from
Nov 13, 2024

Conversation

keellyp
Copy link
Collaborator

@keellyp keellyp commented Oct 31, 2024 •
edited
Loading

Description

Migrate to eslint v9

Best to review commit by commit

Fixes ISSUE-514

@keellyp keellyp added the 🥷 chore This doesn't seem right label Oct 31, 2024
@keellyp keellyp self-assigned this Oct 31, 2024
@keellyp keellyp changed the title Issue 514 eslint chore: migrate eslint to v9 Oct 31, 2024
@keellyp keellyp marked this pull request as draft November 4, 2024 09:40
@keellyp keellyp force-pushed the issue-514-eslint branch 12 times, most recently from c144b34 to 4aceaa5 Compare November 5, 2024 10:45
@keellyp keellyp marked this pull request as ready for review November 5, 2024 10:45
@keellyp keellyp force-pushed the issue-514-eslint branch 2 times, most recently from 7979f08 to 7c9bec2 Compare November 5, 2024 14:41
@keellyp keellyp marked this pull request as draft November 5, 2024 15:14
@ansmonjol
Copy link
Collaborator

Do you wish to keep that PR open until thirdparties get updated @keellyp ?

@ansmonjol ansmonjol mentioned this pull request Nov 12, 2024
Closed
1 task
@keellyp
Copy link
Collaborator Author

keellyp commented Nov 12, 2024 •
edited
Loading

Do you wish to keep that PR open until thirdparties get updated @keellyp ?

Yes, still working in parallel in this PR.
A lot of code has been refactored in order to migrate to v9 however there are still some rules that needs to be addressed (see eslint.config.mjs file). Maybe we can chat about it!

@keellyp keellyp marked this pull request as ready for review November 13, 2024 09:53
@keellyp
Copy link
Collaborator Author

keellyp commented Nov 13, 2024 •
edited
Loading

About newline-after-var deprecated rule, i've created an other ticket : ISSUE-545

@keellyp keellyp merged commit f47c339 into main Nov 13, 2024
4 checks passed
@keellyp keellyp deleted the issue-514-eslint branch November 13, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansmonjol ansmonjol ansmonjol approved these changes

Assignees

@keellyp keellyp

Labels
🥷 chore This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keellyp @ansmonjol