Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: customer name should not be mandatory as on BE #1716

Merged
merged 1 commit into from
Sep 5, 2024
Merged

misc: customer name should not be mandatory as on BE #1716

merged 1 commit into from
Sep 5, 2024

Conversation

ansmonjol
Copy link
Collaborator

BE allows to have not value there, we should allow creating a customer without one.

Note the UI already react well to this as name is optional on the customer type.

This is just to allow the form to be submit in this case

@ansmonjol ansmonjol self-assigned this Sep 5, 2024
@ansmonjol ansmonjol merged commit 599cffe into main Sep 5, 2024
5 checks passed
@ansmonjol ansmonjol deleted the no-name-mandatory branch September 5, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunomiguelpinto brunomiguelpinto brunomiguelpinto approved these changes

Assignees

@ansmonjol ansmonjol

Labels
🌈 improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ansmonjol @brunomiguelpinto