Feat(invoice_custom_sections): api controllers #3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annvelents
force-pushed
the
feat-invoice-custom-sections-customer-update-mutation
branch
3 times, most recently
from
8dba59d to
b99d81b
Compare
annvelents
force-pushed
the
feat-invoice-custom-sections-api-controller
branch
from
232645c to
8e753ee
Compare
annvelents
force-pushed
the
feat-invoice-custom-sections-customer-update-mutation
branch
2 times, most recently
from
7870b8d to
15a84d4
Compare
Base automatically changed from
feat-invoice-custom-sections-customer-update-mutation
to
main
January 9, 2025 14:08
annvelents
force-pushed
the
feat-invoice-custom-sections-api-controller
branch
from
8d3de8e to
8927cbe
Compare
Comment on lines
+14
to
+16
| organization: { | ||
| lago_id: model.organization_id | ||
| } |
There was a problem hiding this comment.
Do we plan to add more organization details in this serializer? If no I would suggest to flatten it (not a blocker ;) )
There was a problem hiding this comment.
yep, makes perfect sense, updating, thank you!
| attr_reader :customer, :section_ids, :skip_invoice_custom_sections | ||
| attr_reader :customer, :section_ids, :skip_invoice_custom_sections, :section_codes | ||
|
|
||
| def raise_double_selection |
There was a problem hiding this comment.
Not sure of the naming here as result.validation_failure! is not raising an error but only marking the result object as failed and adding the error detail to it.
| @skip_invoice_custom_sections = skip_invoice_custom_sections | ||
|
|
||
| super | ||
| end | ||
|
|
||
| def call | ||
| return result.not_found_failure!(resource: "customer") unless customer | ||
| raise_invalid_params if skip_invoice_custom_sections && section_ids.present? | ||
| raise_double_selection if !section_ids.nil? && !section_codes.nil? |
There was a problem hiding this comment.
You might need to return the result here (or am I missing something?)
There was a problem hiding this comment.
oops, yes, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
API controllers to support invoice_custom_sections functionality
Description
Added InvoiceCustomSectionsController and updated customers controller with two new actions