Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(credit-note-export): Add new filters options to credit notes list endpoint #2982

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

floganz
Copy link
Contributor

@floganz floganz commented Dec 19, 2024

Description

Added more filter options to credit notes list endpoint

@floganz floganz self-assigned this Dec 19, 2024
Copy link
Collaborator

@vincent-pochet vincent-pochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good. I only have one question regarding the cleanup of the filter arguments

app/controllers/api/v1/credit_notes_controller.rb Outdated Show resolved Hide resolved
@floganz floganz force-pushed the feat-add-new-filters-to-api branch from bd9043e to c586847 Compare December 20, 2024 12:59
@floganz floganz merged commit de063ee into main Dec 23, 2024
6 checks passed
@floganz floganz deleted the feat-add-new-filters-to-api branch December 23, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants