-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Add Cashfree Payment Provider #2545
Conversation
Thank you very much @AyushChothe for this great contribution. |
Hi @vincent-pochet, Thank you! Please keep me updated on the review process and let me know if any changes are needed. Also, could you guide me on how to run |
To run rspec locally:
lago exec api rspec
# or docker compose -f ./docker-compose.dev.yml exec api rspec
cd api
bundle exec rspec |
f732cbd
to
e9dbde3
Compare
Hey @vincent-pochet, I've addressed all the review comments you mentioned earlier and added test cases for the impacted modules. I wanted to get your thoughts on how we should handle these modules since we aren't creating Here's the list of modules in question: PaymentProviderCustomers::Factory
PaymentProviderCustomers::CreateService
Customers::GenerateCheckoutUrlService I am looking forward to hearing your thoughts! |
e9dbde3
to
8c8ca5a
Compare
Thank you for the update. |
Thanks, that's what I was thinking as well. I'll start working on it now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It start to look great!
Here a few other minor comments
8c8ca5a
to
52e0534
Compare
Hi @vincent-pochet, please review this PR again, including the respective frontend PR at getlago/lago-front#1720. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update. Here are few small comments but I think we are close to something that could be merged 👍
52e0534
to
36b322a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comments regarding the Invoices::Payments::CashfreeService
class :)
If you have some questions around this implementation, we can discuss about it.
36b322a
to
8c716d2
Compare
It looks good to me @AyushChothe! Thank you again for this great contribution 🙏 Someone on the front team will review the pull request on the lago-front repository In the meantime you might have to resync/rebase your branch on the And finally, to fix the failing docker-compose -f $LAGO_PATH/docker-compose.dev.yml exec api rails annotate_models |
Closing this PR in favor of #2767 to perform a QA and ease fixes on Lago's side |
Roadmap Task
👉 https://getlago.canny.io/feature-requests/p/payment-provider-add-integration-for-cashfree-payments
Context
Cashfree Payments is India's leading payment gateway, and with Stripe halting the onboarding of new merchants in India due to regulatory constraints, businesses are left with limited alternatives. Ensuring that Cashfree Payments is available to users is essential, as it will expand Lago's accessibility and appeal to Indian companies, broadening its reach within this crucial market.
We at Pyrite Cloud have begun developing the integration with Cashfree Payments. This will help expand our platform's accessibility, especially for Indian businesses, by providing them with a reliable payment gateway as an alternative to Stripe.
Description
Added Cashfree Payment Provider concerning existing Payment Providers. Still Work in Progress.