Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App::models() #5337

Merged
merged 1 commit into from
Jul 2, 2023
Merged

App::models() #5337

merged 1 commit into from
Jul 2, 2023

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jun 30, 2023 •
edited
Loading

This PR …

Isolated improvement that will help us in the changes refactoring

Enhancement

  • New App::models() method that returns a generator for each model (site, files, pages and users) of the site

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@distantnative distantnative added this to the 4.0.0-alpha.4 milestone Jun 30, 2023
@distantnative distantnative self-assigned this Jun 30, 2023
@distantnative distantnative mentioned this pull request Jul 2, 2023
Merged
3 tasks
@distantnative distantnative merged commit 9788a77 into v4/develop Jul 2, 2023
@distantnative distantnative deleted the v4/refactor/app-models branch July 2, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasbestle lukasbestle lukasbestle approved these changes

@bastianallgeier bastianallgeier Awaiting requested review from bastianallgeier

Assignees

@distantnative distantnative

Labels
None yet
Milestone
4.0.0-alpha.4
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @lukasbestle