Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow publications to specify a separate store for media content #730

Merged
merged 4 commits into from
Apr 6, 2024

Conversation

paulrobertlloyd
Copy link
Collaborator

@paulrobertlloyd paulrobertlloyd commented Apr 3, 2024

Closes #533.

  • Updated publication.store to use either configured value, falling back to the first content store plugin registered (saved to application.stores[])
  • Add publication.mediaStore to use either configured value, else falling back to publication.store.

This means existing configurations won’t break, but publication configuration’s can be updated to specify a separate store to save media files too.

@paulrobertlloyd paulrobertlloyd self-assigned this Apr 3, 2024
@paulrobertlloyd paulrobertlloyd added the enhancement New feature or request label Apr 3, 2024
@paulrobertlloyd paulrobertlloyd added this to the v1.0 milestone Apr 3, 2024
@paulrobertlloyd paulrobertlloyd added plugin-store Store plug-in core Core indiekit package labels Apr 3, 2024
@paulrobertlloyd paulrobertlloyd force-pushed the feat/533-separate-media-store branch from 5e02bf6 to 8805e03 Compare April 3, 2024 22:31
@paulrobertlloyd paulrobertlloyd force-pushed the feat/533-separate-media-store branch 2 times, most recently from bae11ca to 6f91be3 Compare April 6, 2024 20:58
@paulrobertlloyd paulrobertlloyd force-pushed the feat/533-separate-media-store branch from 6f91be3 to 15bbfea Compare April 6, 2024 21:20
@paulrobertlloyd paulrobertlloyd marked this pull request as ready for review April 6, 2024 21:22
@paulrobertlloyd paulrobertlloyd force-pushed the feat/533-separate-media-store branch from 15bbfea to a137e06 Compare April 6, 2024 21:29
@paulrobertlloyd paulrobertlloyd merged commit 04965a9 into main Apr 6, 2024
1 check failed
@paulrobertlloyd paulrobertlloyd deleted the feat/533-separate-media-store branch April 6, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core indiekit package enhancement New feature or request plugin-store Store plug-in
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow different stores to be set post files versus media files
1 participant