Markdown editor #728
Merged
Markdown editor #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulrobertlloyd
force-pushed
the
feat/markdown-editor
branch
10 times, most recently
from
ce0d3fb to
0511cc7
Compare
paulrobertlloyd
force-pushed
the
feat/markdown-editor
branch
from
0511cc7 to
4855b87
Compare
paulrobertlloyd
force-pushed
the
feat/markdown-editor
branch
12 times, most recently
from
24925e8 to
57ecd8f
Compare
paulrobertlloyd
force-pushed
the
feat/markdown-editor
branch
from
57ecd8f to
2c3893f
Compare
paulrobertlloyd
force-pushed
the
feat/markdown-editor
branch
from
2c3893f to
6da525a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By integrating Easy Markdown Editor, it becomes possible to show Markdown with syntax highlighting:
It also adds:
Using fullscreen mode in a web app makes Indiekit’s content editing interface very compelling:
This adds quite a bit of JavaScript so in order to keep the overall asset size low, we need to remove something. Given the little observable different the web font adds, I’ve removed that and gone back to using
system-ui.Overall, when also considering the other frontend optimisations made for this release (namely caching and compression), we actually end up with a more feature rich interface in fewer bytes: