-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor slugs #726
Merged
Merged
Refactor slugs #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulrobertlloyd
added
bug
Something isn't working
code quality
Making things easier to understand
plugin-endpoint
Endpoint plug-in
labels
Mar 29, 2024
paulrobertlloyd
force-pushed
the
refactor/slug
branch
from
March 30, 2024 14:36
d2f39bb
to
56072d0
Compare
paulrobertlloyd
force-pushed
the
refactor/slug
branch
from
March 30, 2024 15:50
26a41b2
to
1ca0292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
code quality
Making things easier to understand
plugin-endpoint
Endpoint plug-in
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argh. Slugs are a pain. They’re an essential component of the Micropub endpoint and need to be stable and predictable as they can affect generated paths (if a path don’t exist in a content store, things quickly fall apart).
This PR:
random
path token #719, such that aslug
property is always created and provided to thepostTemplate
; either from the value provided inmp-slug
, a slugifiedname
property, else a random 5-character string.slug
property not being remembered when a post is deletedslug
property when editing a post{random}
path token, as this token gets regenerated each time therenderPath
function is called{uuid}
path token for the same reasonsslug
property from front matter when using the Eleventy present (Eleventy suppliespage.fileSlug
)slug
property from front matter when using the Jekyll presentslug
property from front matter when using the Hugo present (with Hugoslug
is a significant property that affects the published URL, which may lead to unintended URLs if the slug not being used in the post file path)Need more use cases for it makes sense to supply
slug
property to front matter properties for different static site generators, however if usingpostTemplate
, theslug
property will be provided./cc @aciccarello