Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate URL utility functions #616

Merged
merged 14 commits into from
Jul 4, 2023
Merged

Consolidate URL utility functions #616

merged 14 commits into from
Jul 4, 2023

Conversation

paulrobertlloyd
Copy link
Collaborator

@paulrobertlloyd paulrobertlloyd commented Jul 4, 2023 •
edited
Loading

Consolidates a number of URL utility functions duplicated across different packages:

  • isUrl, used by:
    • create-indiekit
    • endpoint-auth
    • indiekit
  • getCanonicalUrl, used by:
    • endpoint-auth
    • frontend (absoluteUrl)
    • indiekit
    • syndicator-mastodon (getAbsoluteUrl)
    • syndicator-twitter (getAbsoluteUrl)
  • isSameOrigin, used by:
    • syndicator-mastodon (isTootUrl)
    • syndicator-twitter (isTweetUrl)

This reduces the number of tests, down from 632 to 621.

These have been added to a new @indiekit/util package, to which further shared utility functions can be added.

Partly addresses #544.

@paulrobertlloyd
feat(util): add util package
8e670a9
@paulrobertlloyd
feat(util): isUrl
aabe7e1
@paulrobertlloyd
refactor(create-indiekit): use isUrl from util package
2f42e02
@paulrobertlloyd
refactor(endpoint-auth): use isUrl from util package
33d8fcf
@paulrobertlloyd
refactor(indiekit): use isUrl from util package
58c0017
@paulrobertlloyd
feat(util): isSameOrigin
fc6156d
@paulrobertlloyd
refactor(syndicator-mastodon): use isSameOrigin from util package
0466e09
@paulrobertlloyd
refactor(syndicator-twitter): use isSameOrigin from util package
0fd754f
@paulrobertlloyd
feat(util): getCanonicalUrl
3746ad1
@paulrobertlloyd
refactor(endpoint-auth): use getCanonicalUrl from util package
fd6f03a
@paulrobertlloyd
refactor(frontend): use getCanonicalUrl from util package
1b2f833
@paulrobertlloyd
refactor(indiekit): use getCanonicalUrl from util package
7a5fd0d
@paulrobertlloyd
refactor(syndicator-mastodon): use getCanonicalUrl from util package
0c74eba
@paulrobertlloyd
refactor(syndicator-twitter): use getCanonicalUrl from util package
aba46af
@paulrobertlloyd paulrobertlloyd added code quality Making things easier to understand plugin-endpoint Endpoint plug-in plugin-syndicator Syndicator plug-in core Core indiekit package frontend labels Jul 4, 2023
@paulrobertlloyd paulrobertlloyd merged commit af6c63c into main Jul 4, 2023
@paulrobertlloyd paulrobertlloyd deleted the consolidate-url-utils branch July 4, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code quality Making things easier to understand core Core indiekit package frontend plugin-endpoint Endpoint plug-in plugin-syndicator Syndicator plug-in
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paulrobertlloyd