#6 Number subtypes #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getify
reviewed
Feb 22, 2019
getify
reviewed
Feb 22, 2019
…into #6_number-sub-types
getify
reviewed
Feb 22, 2019
getify
reviewed
Feb 23, 2019
| @@ -1457,7 +1449,7 @@ function handleCallExpression(scope,callExprNode,isSelfRecursivePTC = false) { | |||
| let argSignature = typeSignatures.get(argType); | |||
|
|
|||
| if (paramTypeID != "unknown") { | |||
| if (!typesMatch(argType,paramType)) { | |||
| if (!typesMatch(argType,paramType) && paramTypeID != "any") { | |||
There was a problem hiding this comment.
I think this line can just reference the isAssignmentAllowed(..) check now.
There was a problem hiding this comment.
You think this and line 372 are safe to change to use isAssignmentAllowed? I haven't tested for this. Also, these locations don't actually deal with assignments so maybe a more generic function name would be appropriate. Maybe to change isAssignmentAllowed to typesCompatible, that way it would function similar to typesMatch but more permissive.
getify
approved these changes
Feb 23, 2019
| @@ -1672,19 +1671,20 @@ function isAssignmentAllowed(sourceType, targetType){ | |||
| } | |||
|
|
|||
| let matches = { | |||
| any: recognizedTypeIDs, | |||
There was a problem hiding this comment.
Nice... this is a great way to handle it. Thanks!
This was referenced Feb 25, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.