chore: add field for default

[ilevyor]

closes: #82
adds a field for default exports

Summary by CodeRabbit

• New Features
  • Enhanced language parsing capabilities with the introduction of a 'default' rule in JavaScript, TypeScript, and Vue grammars.
• Tests
  • Added new test to ensure the correct replacement of function names in export default statements.
• Chores
  • Improved build process by reordering dependencies and paths in Makefiles across JavaScript, TypeScript, and Vue projects to streamline the build process.

[coderabbitai]

Walkthrough

The recent updates primarily focus on enhancing the parsing and matching capabilities for default export functions in JavaScript and TypeScript, alongside some Makefile adjustments across various language resources. These changes aim to address issues with correctly matching non-anonymous default export functions and improve the build process for development dependencies.

Changes

Files	Summary
crates/core/src/test.rs	Added a test for replacing function names in export default statements.
resources/.../tree-sitter-javascript/grammar.js resources/.../javascript-metavariable-grammar.js resources/.../tree-sitter-javascript/grammar.js	Added a 'default' field and a new rule in grammar files for better default export matching.
resources/.../tree-sitter-typescript/build/Makefile resources/.../tree-sitter-typescript/node_modules/.../build/Makefile resources/.../tree-sitter-vue/build/Makefile resources/.../tree-sitter-vue/node_modules/.../build/Makefile	Reordered dependencies in Makefile target definitions.
resources/.../tree-sitter-vue/build/tree_sitter_vue_binding.target.mk	Adjusted build rules and paths for object files.

Assessment against linked issues

Objective	Addressed	Explanation
Correctly match non-anonymous default export functions in JavaScript and TypeScript (#82)	✅

Poem

In the fields of code, where logic plays,
A rabbit hopped, through syntax maze.
🐇💻 With every leap, a bug squashed flat,
"Export defaults," it fixed, just like that.
Makefiles danced, in ordered lines,
Under moon's soft code-lit signs.
"To better code," it whispered, gleaming,
"We hop, we fix, we keep on dreaming." 🌌🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 409402a and a3603e3.

Files ignored due to path filters (11)

• crates/cli_bin/tests/snapshots/parse__returns_input_file.snap is excluded by: !**/*.snap
• crates/wasm-bindings/wasm_parsers/tree-sitter-javascript.wasm is excluded by: !**/*.wasm
• resources/language-metavariables/tree-sitter-javascript/src/grammar.json is excluded by: !**/*.json
• resources/language-metavariables/tree-sitter-javascript/src/node-types.json is excluded by: !**/*.json
• resources/language-metavariables/tree-sitter-typescript/tsx/src/grammar.json is excluded by: !**/*.json
• resources/language-metavariables/tree-sitter-typescript/tsx/src/node-types.json is excluded by: !**/*.json
• resources/language-metavariables/tree-sitter-typescript/typescript/src/grammar.json is excluded by: !**/*.json
• resources/language-metavariables/tree-sitter-typescript/typescript/src/node-types.json is excluded by: !**/*.json
• resources/node-types/javascript-node-types.json is excluded by: !**/*.json
• resources/node-types/tsx-node-types.json is excluded by: !**/*.json
• resources/node-types/typescript-node-types.json is excluded by: !**/*.json

Files selected for processing (9)

• crates/core/src/test.rs (1 hunks)
• resources/language-metavariables/tree-sitter-javascript/grammar.js (2 hunks)
• resources/language-metavariables/tree-sitter-typescript/build/Makefile (1 hunks)
• resources/language-metavariables/tree-sitter-typescript/node_modules/tree-sitter-javascript/build/Makefile (1 hunks)
• resources/language-metavariables/tree-sitter-typescript/node_modules/tree-sitter-javascript/grammar.js (2 hunks)
• resources/language-metavariables/tree-sitter-vue/build/Makefile (1 hunks)
• resources/language-metavariables/tree-sitter-vue/build/tree_sitter_vue_binding.target.mk (1 hunks)
• resources/language-metavariables/tree-sitter-vue/node_modules/tree-sitter-html/build/Makefile (1 hunks)
• resources/metavariable-grammars/javascript-metavariable-grammar.js (2 hunks)

Files skipped from review due to trivial changes (1)

• resources/language-metavariables/tree-sitter-vue/build/Makefile

Additional comments: 10

resources/language-metavariables/tree-sitter-vue/build/tree_sitter_vue_binding.target.mk (2)

• 139-139: The rule for compiling .c files to .o objects appears correct and follows standard conventions.
• 147-147: Similarly, the rule for compiling .c files from a different source directory is correctly defined.

resources/language-metavariables/tree-sitter-typescript/build/Makefile (1)

• 330-330: The command for regenerating the Makefile is correctly specified, ensuring that the build configuration remains up-to-date with changes to the binding.gyp and related files.

resources/language-metavariables/tree-sitter-vue/node_modules/tree-sitter-html/build/Makefile (1)

• 330-330: The command for regenerating the Makefile is correctly specified, ensuring that the build configuration remains up-to-date with changes to the binding.gyp and related files. This is crucial for maintaining the build process's accuracy and reliability.

resources/language-metavariables/tree-sitter-typescript/node_modules/tree-sitter-javascript/build/Makefile (1)

• 327-333: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-330]

Given the nature of the changes mentioned in the summary, it's crucial to ensure that the reordering of included files or paths in the Makefile does not introduce any dependency issues or affect the build process negatively. It's recommended to verify the build process in different environments to ensure consistency and correctness.

Would you like assistance in setting up automated tests or CI/CD pipelines to verify the build process across different environments?

resources/language-metavariables/tree-sitter-javascript/grammar.js (1)

• 156-163: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [146-160]

The introduction of a new default field and a separate default rule within the export_statement rule is a significant change aimed at correctly distinguishing default export functions from named exports. Ensure that this change aligns with the JavaScript and TypeScript syntax specifications for default exports. Additionally, consider adding more test cases to cover various scenarios involving default exports to ensure the grammar accurately parses them.

Would you like assistance in creating additional test cases for default export scenarios?

resources/language-metavariables/tree-sitter-typescript/node_modules/tree-sitter-javascript/grammar.js (2)

• 146-146: The addition of the 'default' field in the export_statement rule is a significant change. It's crucial to ensure that this aligns with the grammar's syntax and the intended parsing behavior for default exports. This change appears to correctly implement the handling of default exports by distinguishing them from named exports, which addresses the issue outlined in the PR objectives. However, it's important to verify that this new field integrates seamlessly with the rest of the grammar rules and does not introduce any conflicts or ambiguities.
• 159-159: The introduction of a new rule default: _ => 'default' is straightforward and serves to match the 'default' keyword in export statements. This rule is essential for the correct parsing of default export statements, ensuring that they are distinguished from named exports. It's a necessary addition to support the changes made in the export_statement rule and to address the issue described in the PR objectives. Ensure that this rule is consistently used wherever the 'default' keyword needs to be matched in the grammar.

resources/metavariable-grammars/javascript-metavariable-grammar.js (1)

• 156-163: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [146-160]

The introduction of the default field within the export_statement rule is a well-implemented change to address the issue of distinguishing default exports from named exports. This modification aligns with the PR's objectives and should enhance the parser's accuracy in handling export statements in JavaScript and TypeScript.

However, it's essential to verify this change's integration with the rest of the grammar and conduct thorough testing to ensure it doesn't introduce any conflicts or ambiguities.

crates/core/src/test.rs (1)

• 12863-12887: The test limit_export_default_match is well-structured and follows good practices for readability and maintainability. However, consider the following points for improvement:

• Error Handling: Currently, .unwrap() is used for handling potential errors from trim_margin(). While this is acceptable in tests, it's generally a good practice to provide more context or use alternatives like .expect("Error message") for clearer error messages if the unwrap fails.
• Test Verification: Ensure that this test case adequately covers the scenarios related to the issue it addresses. It might be beneficial to add more test cases or variations to thoroughly test the new grammar rules for default exports.