chore: consolidate as_node()

[arendjr]

See discussion at: #85 (comment)

I've followed @ilevyor 's suggestion to return None for the empty and list variants, although I ended up calling it as_node() for consistency with the as_filename() method we also have now.

Summary by CodeRabbit

• Refactor
  • Improved handling and retrieval of file paths and nodes within the core binding structure.
  • Enhanced logic for inserting text padding in patterns, ensuring more accurate formatting.

[coderabbitai]

Walkthrough

The recent updates focus on refining the handling of bindings and nodes within a codebase, particularly emphasizing the correct identification and processing of file names and node types. Changes streamline the interface for retrieving node information from bindings, ensuring more direct and type-safe operations. Additionally, a subtle yet impactful adjustment in the handling of text padding enhances the precision of pattern resolution, contributing to overall codebase efficiency and clarity.

Changes

Files	Change Summary
.../src/binding.rs	Updated as_filename for direct FileName checks; redefined as_node for node type handling.
.../src/pattern/after.rs, .../src/pattern/before.rs	Corrected method from get_node() to as_node() for node retrieval from a binding.
.../src/pattern/resolved_pattern.rs	Adjusted get_insertion_padding logic by refining text parameter handling.

🐇✨
In the realm of code, where bindings intertwine,
A rabbit hopped through, making changes so fine.
'Neath the moon's soft glow, and the stars' gentle shine,
It tweaked and it tuned, till the patterns align.
With a hop, skip, and a jump, all was defined,
In the world of the code, where our paths intertwine.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[arendjr]

Resolves a Clippy.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 8d0cdf4 and 32e2bce.

Files selected for processing (4)

• crates/core/src/binding.rs (2 hunks)
• crates/core/src/pattern/after.rs (1 hunks)
• crates/core/src/pattern/before.rs (1 hunks)
• crates/core/src/pattern/resolved_pattern.rs (1 hunks)

Additional comments: 5

crates/core/src/pattern/after.rs (1)

• 58-58: The replacement of get_node() with as_node() aligns with the PR's objective to standardize node retrieval. Ensure that as_node() comprehensively handles all scenarios previously covered by get_node(), including error handling and edge cases.

crates/core/src/pattern/before.rs (1)

• 58-58: The replacement of get_node() with as_node() aligns with the PR's objective to standardize node retrieval. Ensure that as_node() comprehensively handles all scenarios previously covered by get_node(), including error handling and edge cases.

crates/core/src/binding.rs (2)

• 478-485: The modification to the as_filename method simplifies its logic by directly returning the path for a FileName variant, which is a positive change that enhances clarity and efficiency.
• 487-492: The redefinition of the as_node method to return a NodeWithSource for node type bindings aligns with the PR's objective to standardize node handling. Ensure that as_node() comprehensively handles all scenarios previously covered by its old definition.

crates/core/src/pattern/resolved_pattern.rs (1)

• 992-992: The change in how get_insertion_padding is called, specifically the handling of the text parameter, may affect the logic related to padding insertion. It's important to verify that this change does not introduce regressions or unintended behavior in padding insertion logic.