Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add C# language support #585

Merged
merged 7 commits into from
Dec 3, 2024
Merged

Conversation

urbit-pilled
Copy link
Contributor

@urbit-pilled urbit-pilled commented Dec 2, 2024

/claim #438

PS: The tree-sitter-c-sharp submodule has introduced a new tree-sitter-language crate (https://crates.io/crates/tree-sitter-language) to decouple grammar parsing with the rest of tree-sitter. Unfortunately this is incompatible with tree-sitter-facade so I reverted the tree-sitter-language changes.

This is why the submodule doesn't point to the official tree-sitter-c-sharp repository.

@urbit-pilled urbit-pilled requested a review from a team as a code owner December 2, 2024 02:47
@algora-pbc algora-pbc bot mentioned this pull request Dec 2, 2024
@urbit-pilled urbit-pilled changed the title Add c sharp feat: Add C# language support Dec 2, 2024
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would just love a few more tests to award the bounty. Also please run this on a real C# repo and confirm it works.

@morgante morgante merged commit 7acf2cf into getgrit:main Dec 3, 2024
9 of 11 checks passed
@urbit-pilled
Copy link
Contributor Author

Thanks for the review @morgante.
I'll add more tests, test it out on a real repo and add tests within LINQ queries when I get the time (hopefully later today or tomorrow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants