fix: 539 ensure correctly skipping files based on nested .gitignore files

[Alex-ley-scrub]

/claim #539

fixes #539

see https://docs.rs/ignore/latest/ignore/struct.WalkBuilder.html#ignore-rules

Greptile Summary

This is an auto-generated summary

Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/usage

[greptile-apps]

LGTM

_{17 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile}

[Alex-ley-scrub]

@morgante - I can't seem to replicate what you are seeing in #539 ? Do you have an example command that fails?

These commands (now in a test) work as I would expect them to? Correct files are ignored.

cd src/module1
grit apply '`object` => ``' . --lang=py --force

cd src/module2
grit apply '`object` => ``' . --lang=py --force

I think that the ignore::Walk already does this (see description on docs.rs) - I do also have some code locally that also manually adds the .gitignore files to the ignore::Walk but there's no point pushing it if it is not needed. Although if you can share a command with me that does fail to ignore them - then I'm happy to push it of course.

I added a test that I think captures the desired behaviour:

gritql/crates/cli_bin/tests/apply.rs

Lines 2925 to 2928 in a7d5bd3

	// root .gitignore has *.rst and *.pyi and file3.py
	// src .gitignore has !module1/*.pyi and !module2/*.rst
	// src/module1 .gitignore has !*.rst
	// src/module2 .gitignore has file1.py and !file3.py

gritql/crates/cli_bin/tests/apply.rs

Lines 2930 to 2938 in a7d5bd3

	// in this folder we should process file1.py and file2.pyi BUT NOT file3.py
	let module1 = fixture_dir.join("src/module1");
	let mut cmd = get_test_cmd()?;
	cmd.arg("apply")
	.arg("`object` => ``")
	.arg(".")
	.arg("--lang=py")
	.arg("--force")
	.current_dir(&module1);

gritql/crates/cli_bin/tests/apply.rs

Lines 2959 to 2967 in a7d5bd3

	// in this folder we should ONLY process file3.py and NOT file2.pyi NOR file1.py
	let module2 = fixture_dir.join("src/module2");
	let mut cmd = get_test_cmd()?;
	cmd.arg("apply")
	.arg("`object` => ``")
	.arg(".")
	.arg("--lang=py")
	.arg("--force")
	.current_dir(&module2);

[Alex-ley-scrub]

I think that the ignore::Walk already does this (see description on docs.rs) - I do also have some code locally that also manually adds the .gitignore files to the ignore::Walk but there's no point pushing it if it is not needed. Although if you can share a command with me that does fail to ignore them - then I'm happy to push it of course.

[morgante]

Thanks for investigating, it looks like I'm unable to reproduce this too. Sorry for the mixup!