Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repair tracing and add hyperdx #318

Merged
merged 14 commits into from
May 8, 2024
Merged

fix: repair tracing and add hyperdx #318

merged 14 commits into from
May 8, 2024

Conversation

morgante
Copy link
Contributor

@morgante morgante commented May 8, 2024

I'm turning on tracing by default so we don't break it in the future (we can still disable for prod builds).

Summary by CodeRabbit

  • New Features

    • Enhanced tracing capabilities across various modules for improved monitoring and debugging.
    • Introduced new functions to support command execution with integrated tracing.
  • Bug Fixes

    • Updated tracing attributes to standardize instrumentation practices.
  • Refactor

    • Transitioned several functions to utilize enhanced tracing features.
    • Removed outdated tracing setup and replaced it with a more streamlined approach.
  • Chores

    • Added and updated dependencies related to tracing and OpenTelemetry to support new features.

@morgante morgante marked this pull request as ready for review May 8, 2024 06:04
@morgante morgante requested a review from a team as a code owner May 8, 2024 06:04
Copy link
Contributor

coderabbitai bot commented May 8, 2024

Walkthrough

The recent changes focus on enhancing tracing and telemetry capabilities throughout the software system. These updates include the addition of dependencies for tracing and OpenTelemetry, integration of tracing annotations in various functions for improved monitoring, and adjustments to command execution functions to support tracing with OpenTelemetry integration. These changes aim to enhance observability and facilitate monitoring and debugging using tools like Grafana and Honeycomb.

Changes

File Path Change Summary
.../cli/Cargo.toml, .../cli_bin/Cargo.toml, .../gritmodule/Cargo.toml Added various tracing and telemetry dependencies.
.../cli/src/commands/apply_pattern.rs, .../cli/src/commands/filters.rs, .../cli/src/resolver.rs, .../cli/src/updater.rs, .../gritmodule/src/patterns_directory.rs Added tracing annotations to functions for enhanced monitoring.
.../cli/src/commands/mod.rs, .../cli_bin/src/main.rs Modified command execution functions to incorporate tracing, including setup and retrieval of OpenTelemetry keys.
.../core/src/problem.rs Updated tracing instrumentation in the Problem struct's method.
.../cli_bin/tests/plumbing.rs Removed assertions related to empty stderr in test functions.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

crates/cli/src/commands/mod.rs Show resolved Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@morgante morgante merged commit 976b9c6 into main May 8, 2024
6 checks passed
@morgante morgante deleted the hyperdx branch May 8, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants