fix: clippy

[ilevyor]

clippy isn't run on external contributors code, fixes clips lints.

Summary by CodeRabbit

• Refactor
  • Improved code readability and control flow in core functionalities.
• Chores
  • Updated internal documentation and annotations to enhance code quality.
• Bug Fixes
  • Addressed a potential issue in the Binding implementation to prevent an infinite loop.

[coderabbitai]

Walkthrough

The recent update focuses on enhancing code readability and addressing potential issues with infinite loops in the core library. Specifically, a suggestion was made to potentially eliminate an external loop, marked by an attribute to suppress a common lint warning. Additionally, the update improves the control flow in a function dedicated to comment analysis by utilizing a match expression for clearer logic and readability.

Changes

File Path	Change Summary
.../src/binding.rs	Added comment and #[allow(clippy::never_loop)] attribute to refine loop handling.
.../src/suppress.rs	Enhanced comment_occupies_entire_line function with a match expression for better readability.

🐇✨
In the realm of code, where logic weaves,
A rabbit hopped, tweaking the leaves.
Loops untangled, with a clever twist,
Comments shine, in clarity's midst.
Through patterns matched, the code now sings,
A tale of fixes, on digital wings.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[grit-app]

On commit d5f8a06, Grit tried to heal these tests:

Job	Original Status	Final Status
code quality / clippy	❌ Failed	✅ Passed on retry #2 after trying strategies ai, rerun
code quality / clippy_check	❌ Failed	❗ Failed on attempt #3 after trying strategies ai, rerun

Tip

You can view and edit CI healing settings on the Grit App.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 542cca3 and d5f8a06.

Files selected for processing (2)

• crates/core/src/binding.rs (1 hunks)
• crates/core/src/suppress.rs (1 hunks)

Additional comments (1)

crates/core/src/binding.rs (1)

• 543-545: The use of #[allow(clippy::never_loop)] along with the explanatory comment is appropriate for addressing the Clippy lint in this context. It's good practice to provide such comments when disabling lints to ensure future maintainers understand the reasoning.

[coderabbitai]

Consider using a char instead of a string constant for splitting, as it's more efficient and clearer.

-        .zip_longest(text.split("\n"))
+        .zip_longest(text.split('\n'))

---

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	.zip_longest(text.split("\n"))
	.zip_longest(text.split('\n'))

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between d5f8a06 and 4a4fea0.

Files selected for processing (1)

• crates/core/src/suppress.rs (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• crates/core/src/suppress.rs