Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to enter combination keys #192

Closed
rajeshvaran opened this issue Oct 1, 2018 · 3 comments
Closed

Need a way to enter combination keys #192

rajeshvaran opened this issue Oct 1, 2018 · 3 comments
Assignees

Comments

@rajeshvaran
Copy link

There should be a way to enter the combination of keys like 'Shift + Tab' for the press function.
Currently, the below sequence of command is not actually doing the intended behavior of shift + tab

Press('Shift')
Press('Tab')

Expected behavior

A combination of shift + Tab is pressed so that the focus is on the previous element in the sequence.

Actual behavior

The focus is on the next element in the sequence.

Steps to reproduce

Versions

Paste `node` and `taiko` versions here.
@BugDiver
Copy link
Member

BugDiver commented Oct 10, 2018

There are some issues with pressing key combinations. Some key combination works fine other there are a bunch of cases which does not work.
Example -

  • Ctrl-A, Ctrl-R Alt-SOME_KEY does not work.
  • Shift -Tab, Shift-ArrowLeft works.

The CDP has limitations that it can control only page actions.

Some of the combinations are os handled actions, not browser handled.
Ref - puppeteer/puppeteer#1313

@zabil
Copy link
Member

zabil commented Oct 10, 2018

It's ok to ignore OS handled actions.

@BugDiver
Copy link
Member

The decided syntax to press combinations is -
press(['FisrtKey', 'SecondKey', ....])
The fix should be availabe in commit 499249f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants