Custom parameters support + Hook conflict fix #182
Conversation
BugDiver
commented
Jun 16, 2024
BugDiver
commented
- Add support for custom parameter parsing Add support for enum parameters #5
- Fix conflicting hooks issues multiple @BeforeSuite conflict #138
* Parse primitive paramters * Support custom parameter parser Signed-off-by: BugDiver <[email protected]>
Signed-off-by: BugDiver <[email protected]>
docs/index.md
Outdated
| @@ -309,6 +309,63 @@ String elementId = scenarioStore.get("element-id") as string; | |||
|
|
|||
| ``` | |||
|
|
|||
| ### Custom Paramter Parsers | |||
There was a problem hiding this comment.
| ### Custom Paramter Parsers | |
| ### Custom Parameter Parsers |
e2e/tests/implementation.ts
Outdated
| @Step("This step uses a custom parameter of type Person and value <person>") | ||
| public async validatePerson(person: Person) { | ||
| assert.equal(person.name, "John"); | ||
| assert.equal(person.age, 30); |
There was a problem hiding this comment.
Can we change these to use strictEqual? I noticed that even if the parameter was declared as a number in earlier versions the number is actually passed as string and fails when we do a ===
There was a problem hiding this comment.
Yes, this should be fixed now, as we are doing primitive conversion. Just to highlight, parameters which are part of a table (string or int or bool) are still treated as string. As of now we are not doing nested conversion.
Signed-off-by: BugDiver <[email protected]>
Signed-off-by: BugDiver <[email protected]>
BugDiver
force-pushed
the
custom-paramaters
branch
from
79b4754 to
ffd91c0
Compare
BugDiver
added
the
ReleaseCandidate
|
@BugDiver Thank you for contributing to gauge-ts. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
