Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacktrace with error in js line should be clickable #83

Closed
sswaroopgupta opened this issue Dec 12, 2017 · 6 comments
Closed

Stacktrace with error in js line should be clickable #83

sswaroopgupta opened this issue Dec 12, 2017 · 6 comments
Assignees
Labels

Comments

@sswaroopgupta
Copy link
Contributor

Expected behavior
The line number indicating the error in js file should be clickable.

Actual behavior
When the error is request timeout the stacktrace indicating the failure is not clickable

Steps to replicate

  • LSP Tests with request timeout

Observe the goto definition spec error in the stacktrace https://travis-ci.org/getgauge/gauge-lsp-tests/builds/315198558

Version

Gauge version: 0.9.6.nightly-2017-12-08
Commit Hash: 0b85c7e
Plugins
-------
html-report (4.0.3.nightly-2017-12-08)
js (2.0.3.nightly-2017-11-30)
xml-report (0.2.1.nightly-2017-10-26)
@sswaroopgupta sswaroopgupta changed the title Stacktrace with error in js line is not clickable when error is request timeout Stacktrace with error in js line should be clickable Dec 14, 2017
@sswaroopgupta
Copy link
Contributor Author

sswaroopgupta commented Dec 14, 2017

Issue
The error path is getting concatenated with relative path twice
Tracked as - getgauge/gauge-vscode#79

*Issue
Error in stacktrace is incoplete
Traced as - getgauge/gauge-vscode#80

@sswaroopgupta
Copy link
Contributor Author

Issue
When there is a space in the file/filePath the error link in the stacktrace is limited to the first occurrence of the space.

@sswaroopgupta
Copy link
Contributor Author

sswaroopgupta commented Dec 15, 2017

Issue
Current project path is getting appended to external library

Tracked as - getgauge/gauge-vscode#78

@Apoorva-GA
Copy link
Contributor

@sguptatw the above issue looks like a different issue. Could you please create a new issue?

@riju91
Copy link
Contributor

riju91 commented Dec 18, 2017

Vscode's default document link provider does not support spaces in filenames. Incorrect Document links are generated for the files which have space in their names since only the part of the filename till the first space in considered for the link which result in incorrect links.
Possible resolution could be adding custom document link providers.

Please refer to issue in vscode

@sswaroopgupta
Copy link
Contributor Author

Tracking other issues in different issue cards.

@ghost ghost removed the in progress label Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants