refactor: Respect source transaction boundaries #2335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the mechanism of pipeline
Commit
message generation.Connector behaviour change
- Connector's "state" used to be defined per table asHashMap<String, TableState>
, now it's a singleSourceState
.IngestionMessage::TransactionInfo(TransactionInfo::Commit)
messages on transaction boundary.Pipeline behaviour change
Commit
used to be generated whenever a source has ingested a certain number of operations, or certain time has passed. Now it's generated when all sources happen to be at a transaction boundary.Note that if there are multiple sources and data keep flow in, it's possible that pipeline
Commit
is never generated, because when source A is at transaction boundary, source B isn't necessarily that.@karolisg I need your review on the postgres connector.
@abcpro1 I need your review on the mysql connector.