Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance: Update dokan admin dashboard logo & add logo update notice. #2258

Merged
merged 25 commits into from
Nov 15, 2024

Conversation

MdAsifHossainNadim
Copy link
Contributor

@MdAsifHossainNadim MdAsifHossainNadim commented Apr 26, 2024

Enhance: Update dokan admin logo & add logo update notice.

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included related pull request(s) (optional)
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

Closes

How to test the changes in this Pull Request:

  • Go to dokan admin dashboard & see menu logo, admin settings logo, admin logo notice etc.

Changelog entry

Fix: Update dokan admin dashboard logo & add logo update notice.

Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.

Before Changes

image

After Changes

Screenshot 2024-04-26 at 4 25 58 PM

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

Summary by CodeRabbit

Release Notes

  • New Features

    • Updated admin notices with a new logo update notification.
  • Styling Improvements

    • Enhanced styles for admin header, menu interactions, and various components to improve visual consistency and responsiveness.
    • Introduced new color variables for a unified color scheme across multiple components.
    • Updated button styles and background effects for better visibility and interaction.
    • Improved visual presentation of the vendor capabilities and premium pages for enhanced clarity.
    • Simplified background styles and enhanced layout for the Module Upgrade and Pro CTA components.
    • Enhanced media queries for better responsiveness of admin notices.
  • Bug Fixes

    • Improved transition effects for admin notices, ensuring smoother animations and better visibility.

These updates aim to create a more cohesive and user-friendly interface for the admin panel.

@MdAsifHossainNadim MdAsifHossainNadim added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval labels Apr 26, 2024
@MdAsifHossainNadim MdAsifHossainNadim self-assigned this Apr 26, 2024
@MdAsifHossainNadim
Copy link
Contributor Author

@shohag121 Vhaiya, kindly review this PR at your convenience.

@shohag121 shohag121 added 👍 Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels Apr 29, 2024
@shashwatahalder01 shashwatahalder01 added QA In Progress and removed Needs: Testing This requires further testing labels Apr 29, 2024
@shashwatahalder01 shashwatahalder01 added QA approved This PR is approved by the QA team and removed QA In Progress QA approved This PR is approved by the QA team labels Apr 29, 2024
@shashwatahalder01

This comment was marked as resolved.

includes/Admin/Notices/Manager.php Outdated Show resolved Hide resolved
includes/Admin/Notices/Manager.php Outdated Show resolved Hide resolved
includes/Admin/Notices/Manager.php Outdated Show resolved Hide resolved
includes/Admin/Notices/Manager.php Outdated Show resolved Hide resolved
includes/Admin/Notices/Manager.php Outdated Show resolved Hide resolved
includes/Admin/Notices/Manager.php Outdated Show resolved Hide resolved
@MdAsifHossainNadim
Copy link
Contributor Author

@mrabbani Vhai, need to relevant ui's for new issues.
@shashwatahalder01 Vhai, If anything is required or if you have any suggestions for us, then feel free to inform us.

@shashwatahalder01

This comment was marked as resolved.

@tuhin480
Copy link

tuhin480 commented May 7, 2024

Here is the Design Link. Please have a look.

@MdAsifHossainNadim
Copy link
Contributor Author

MdAsifHossainNadim commented May 16, 2024

@tuhin480 Vhai, we need to make consistent between existing banner & updated logo. Here is the preview after updating logo.

Screenshot 2024-05-08 at 9 27 54 AM
Screenshot 2024-05-08 at 9 27 07 AM

I think It will be better if we added some shadow or spaces on left/bottom side in this banner image. (as like as previous)

image

Screenshot 2024-05-08 at 9 55 21 AM

We need to update wp org's banner & icon logo's as per latest update.

image (35)

CC: @mrabbani @ashrafux

@tuhin480
Copy link

tuhin480 commented Aug 28, 2024

This issue was split into two different GitHub links, which caused a delay. I've completed all the tasks and would like to request you to review the design.
Design Link
Cc: @ashrafux @mrabbani @Mohaiminulislam1989

@mrabbani
Copy link
Member

This issue was split into two different GitHub links, which caused a delay. I've completed all the tasks and would like to request you to review the design. Design Link Cc: @ashrafux @mrabbani @Mohaiminulislam1989

@imtiaz-pranto via, Pls review design and let us know your feedback.

@jamil-mahmud
Copy link

@shashwatahalder01 vaia,

Task:

  • You will check the last worked branch of this issue and find each and every place in the plugin product in how many places Dokan New Logo is replaced.
  • You will update the issue list based on how many places new logo and branding are yet to be changed (Basic Logo, Icon, Branding Logo Banner)

Resource:
-- From our analysis, here is an impact list document where there are possibilities of changes. Still if you find extra places missed from the document kindly mention that in your report. --- Impact List DOC

Timeline

  • Reply me an estimated timeline when you will complete this. Thank You

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)
includes/Admin/Notices/Manager.php (3)

131-133: Update the @since tag with the actual version number.

Replace DOKAN_SINCE with the actual version number where this feature was introduced.


158-163: Update the @since tag with the actual version number.

Replace DOKAN_SINCE with the actual version number where this feature was introduced.


168-177: Improve permission check documentation.

Consider adding more context to the @since tag and parameter documentation to explain why manage_woocommerce capability is required.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5ce15dd and 4944af4.

📒 Files selected for processing (1)
  • includes/Admin/Notices/Manager.php (3 hunks)
🔇 Additional comments (3)
includes/Admin/Notices/Manager.php (3)

51-52: LGTM: Hook registration follows WordPress standards.

The new hooks are properly registered and follow WordPress naming conventions.


Line range hint 139-156: LGTM: Notice implementation follows WordPress standards.

The notice implementation is well-structured with:

  • Proper type hints
  • Approved content from the content team
  • Correct dismissal configuration

177-191: LGTM: Secure implementation of notice dismissal.

The implementation follows WordPress security best practices:

  • Proper nonce verification
  • Permission checks
  • Data sanitization

@mrabbani mrabbani added Needs: Testing This requires further testing 👍 Dev Review Done and removed Type: Bug Needs: Dev Review It requires a developer review and approval labels Nov 7, 2024
@shashwatahalder01 shashwatahalder01 added QA In Progress and removed Needs: Testing This requires further testing labels Nov 12, 2024
@shashwatahalder01

This comment was marked as resolved.

@shashwatahalder01

This comment was marked as resolved.

@osmansufy

This comment was marked as outdated.

@shashwatahalder01

This comment was marked as resolved.

@shashwatahalder01

This comment was marked as resolved.

@shashwatahalder01 shashwatahalder01 added QA approved This PR is approved by the QA team and removed QA In Progress labels Nov 15, 2024
@mrabbani mrabbani merged commit ac4cf67 into develop Nov 15, 2024
2 checks passed
@mrabbani mrabbani deleted the enhance/update-dokan-logo-&-add-logo-update-notice branch November 15, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA approved This PR is approved by the QA team 👍 Dev Review Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants