Fix: pr reviews

getdokan · Oct 8, 2024 · 8dae527 · 8dae527
1 parent d0ee88c
commit 8dae527
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/tests/pw/pages/productsPage.ts b/tests/pw/pages/productsPage.ts
@@ -1427,7 +1427,7 @@ export class ProductsPage extends AdminPage {
         await this.selectByValue(productsVendor.addon.formatTitle, addon.formatTitle);
         await this.check(productsVendor.addon.addDescription);
         await this.clearAndType(productsVendor.addon.descriptionInput, addon.addDescription);
-        await this.click(productsVendor.addon.requiredField);
+        await this.check(productsVendor.addon.requiredField);
         // option
         await this.clearAndType(productsVendor.addon.option.enterAnOption, addon.enterAnOption);
         await this.selectByValue(productsVendor.addon.option.optionPriceType, addon.optionPriceType);
@@ -1453,7 +1453,7 @@ export class ProductsPage extends AdminPage {
         await this.toBeChecked(productsVendor.addon.excludeAddons);
     }
 
-    // export addon
+    // import addon
     async importAddon(productName: string, addon: string, addonTitle: string): Promise<void> {
         await this.goToProductEdit(productName);
         await this.click(productsVendor.addon.import);

diff --git a/tests/pw/pages/requestForQuotationsPage.ts b/tests/pw/pages/requestForQuotationsPage.ts
@@ -119,7 +119,7 @@ export class RequestForQuotationsPage extends AdminPage {
             await this.clearAndType(requestForQuotationAdmin.quoteRules.addNewQuoteRule.hidePriceText, rule.hidePriceText);
         } else {
             if (rule.hideAddToCartButton) await this.click(requestForQuotationAdmin.quoteRules.addNewQuoteRule.hideAddToCartButton);
-            if (rule.hideAddToCartButton) await this.click(requestForQuotationAdmin.quoteRules.addNewQuoteRule.keepBothAddToCartAndQuoteButton);
+            if (rule.keepBothCartQuoteButton) await this.click(requestForQuotationAdmin.quoteRules.addNewQuoteRule.keepBothAddToCartAndQuoteButton);
         }
         await this.clearAndType(requestForQuotationAdmin.quoteRules.addNewQuoteRule.customButtonLabel, rule.customButtonLabel);
 

diff --git a/tests/pw/tests/e2e/productsDetails.spec.ts b/tests/pw/tests/e2e/productsDetails.spec.ts
@@ -448,8 +448,8 @@ test.describe('Product details functionality test', () => {
     });
 
     test('vendor can remove product addon', { tag: ['@pro', '@vendor'] }, async () => {
-        const [, , productName, addonName] = await apiUtils.createProductWithAddon(payloads.createProduct(), [payloads.createProductAddon()], payloads.vendorAuth);
-        await vendor.removeAddon(productName, addonName[0] as string);
+        const [, , productName, addonNames] = await apiUtils.createProductWithAddon(payloads.createProduct(), [payloads.createProductAddon()], payloads.vendorAuth);
+        await vendor.removeAddon(productName, addonNames[0] as string);
     });
 
     // rma options