This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
Pin time to 0.3.9 because of debug assert panic
#2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the rollover tests (may) panic. We can bump the version once time-rs/time#481 is resolved.
bonomat
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
The bug appears only if the time difference is in nano seconds.
We should keep an eye on time and upgrade once they release a new version. There seem to be already a bug fix for this issue: time-rs/time#482
|
bors r+ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the rollover tests (may) panic.
We can bump the version once time-rs/time#481 is resolved.
I am still surprised that the tests did not fail when we merged the bump. This would mean this is only a problem sometimes, which is not good. I wonder if there is a bigger problem in
timethat may cause issues. (@klochowicz mentioned this in #2274 as well).Resolves #2274