Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add closing tx #2099

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Feat: Add closing tx #2099

merged 5 commits into from
Feb 28, 2024

Conversation

holzeis
Copy link
Contributor

@holzeis holzeis commented Feb 26, 2024

Adds the closing txid to the dlc channels api and the channels screen in the settings (see screenshot below).

depends on get10101/rust-dlc#13

Note this is a breaking change. Old closed channels can't be read anymore. But given that old closed channel state don't provide any valuable information, I think this is acceptable.

image

@holzeis holzeis requested review from bonomat and luckysori February 26, 2024 14:09
@holzeis holzeis self-assigned this Feb 26, 2024
@holzeis holzeis linked an issue Feb 26, 2024 that may be closed by this pull request
Add closing transaction to Channel::Closed #2010
Closed
luckysori
luckysori approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@luckysori luckysori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

coordinator/src/collaborative_revert.rs Show resolved Hide resolved
crates/ln-dlc-node/src/ln/dlc_channel_details.rs Outdated Show resolved Hide resolved
crates/ln-dlc-node/src/ln/dlc_channel_details.rs Outdated Show resolved Hide resolved
mobile/lib/common/settings/channel_screen.dart Outdated Show resolved Hide resolved
@holzeis holzeis force-pushed the feat/add-closing-tx branch from 92e2e86 to f36fb07 Compare February 27, 2024 15:20
@holzeis holzeis changed the base branch from main to chore/record-contract-transactions February 27, 2024 15:20
@holzeis holzeis force-pushed the chore/record-contract-transactions branch from 37c7d83 to 3c58a99 Compare February 28, 2024 10:14
@holzeis holzeis force-pushed the feat/add-closing-tx branch from f36fb07 to 07fecc3 Compare February 28, 2024 10:15
Base automatically changed from chore/record-contract-transactions to main February 28, 2024 10:43
@holzeis holzeis force-pushed the feat/add-closing-tx branch from 07fecc3 to e94d1c5 Compare February 28, 2024 12:32
bonomat
bonomat approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@bonomat bonomat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the webapp as well please, I think this can come very handy there :)

@holzeis holzeis enabled auto-merge February 28, 2024 12:53
@holzeis holzeis added this pull request to the merge queue Feb 28, 2024
Merged via the queue into main with commit 2b2ef4d Feb 28, 2024
20 checks passed
@holzeis holzeis deleted the feat/add-closing-tx branch February 28, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luckysori luckysori luckysori approved these changes

@bonomat bonomat bonomat approved these changes

Assignees

@holzeis holzeis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add closing transaction to Channel::Closed
3 participants
@holzeis @bonomat @luckysori